Re: [PATCH v4 06/10] dt-bindings: i3c: cdns: add Axiado AX3000 I3C controller

[Krzysztof Kozlowski]

On 01/07/2025 22:27, Harshit Shah wrote:
> Add binding for AX3000 I3C controller. So far, no changes known,
> so it can fallback to default compatible.
> 
> Signed-off-by: Harshit Shah <hshah@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> index cad6d53d0e2e35ddaaad35215ec93dd182f28319..bd3f31a03376b3351276ae2cd247615ee4eff52f 100644
> --- a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> @@ -14,7 +14,13 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: cdns,i3c-master
> +    oneOf:
> +      - description: Cadence I3C controller
> +        const: cdns,i3c-master
> +      - description: Axiado AX3000 I3C controller

Same comments, drop descriptions,

> +        items:
> +          - const: axiado,ax3000-i3c

This should be enum.

> +          - const: cdns,i3c-master
>  
>    reg:
>      maxItems: 1
> 


Best regards,
Krzysztof