Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext()

[David Hildenbrand]

On 30.06.25 13:18, Lorenzo Stoakes wrote:
> On Mon, Jun 30, 2025 at 01:16:52PM +0200, David Hildenbrand wrote:
> > > @ptentp: Pointer to a COPY of the first page table entry whose flags we update
> > >            if appropriate.
> >
> > + * @ptentp: Pointer to a COPY of the first page table entry whose flags this
> > + *         function updates based on @flags if appropriate.
> >
> >
> > > And then update the description of folio_pte_batch_flags() both the brief one to
> > > add 'updates ptentp to set flags if appropriate' and maybe in the larger
> > > description bit.
> >
> > Not in the brief one; the other description, including the excessive parameter doc
> > will be enough.
>
> That works for me! Let's not hold this up on trivia.
>
> > FWIW, I briefly though passing in an arg struct, or returning the pte instead (and returning
> > the nr_pages using a parameter), but hated both. More than these two stupid pte*.
>
> Well I love help structs bro so you know I'd love that ;)

Yeah, I was more annoyed by a possible the folio_pte_batch() vs. 
folio_pte_batch_ext /_flags() inconsistency.

I'll think about this once more ... :)

--
Cheers,

David / dhildenb