Re: [PATCH] drivers: staging: iio: frequency: ad9832.h: Fixed TODO note.

From: Greg Kroah-Hartman
Date: Sat Jun 28 2025 - 02:08:57 EST


On Fri, Jun 27, 2025 at 08:51:14PM +0300, Abdalla Al-Dalleh wrote:
> - drivers/staging/iio/frequency/ad9832.c: Changed .h file location
> - drivers/staging/iio/frequency/ad9832.h: Removed struct definition
> - include/linux/iio/dac/ad9832.h: Added header file according to the
> TODO note.
>
> Signed-off-by: Abdalla Al-Dalleh <abdalla.ahmad@xxxxxxxxxxxxx>
> ---
> drivers/staging/iio/frequency/ad9832.c | 3 +--
> drivers/staging/iio/frequency/ad9832.h | 23 ------------------
> include/linux/iio/dac/ad9832.h | 33 ++++++++++++++++++++++++++

Staging drivers need to be "self-contained" for now.

Why do you even need a .h file for a single .c file anyway? Why not
just remove it?

thanks,

greg k-h