Re: [PATCH v2] cgroup/rstat: change cgroup_base_stat to atomic

From: tj@xxxxxxxxxx
Date: Fri Jun 27 2025 - 12:51:07 EST


Hello,

On Fri, Jun 27, 2025 at 01:15:31PM +0000, Wlodarczyk, Bertrand wrote:
...
> > Also the response to the tearing issue explained by JP is not satisfying.
>
> In other words, the claim is: "it's better to stall other cpus in spinlock plus disable IRQ every time in order to
> serve outdated snapshot instead of providing user to the freshest statistics much, much faster".
> In term of statistics, freshest data served fast to the user is, in my opinion, better behavior.

This is a false choice, I think. e.g. We can easily use seqlock to remove
strict synchronization only from user side, right?

> I wouldn't be addressing this issue if there were no customers affected by rstat latency in multi-container
> multi-cpu scenarios.

Out of curiosity, can you explain the case that you observed in more detail?
What were the customer doing?

Thanks.

--
tejun