Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx

[Sean Nyekjaer]

Hi,

On Sat, Jun 21, 2025 at 11:13:33AM +0100, Vincent Mailhol wrote:
> On 20/06/2025 at 19:00, Sean Nyekjaer wrote:
> > Wrap the "msg lost in rxf0" error in m_can_handle_lost_msg() with
> > a call to net_ratelimit() to prevent flooding the kernel log
> > with repeated error messages.
> 
> Note that another solution is to simply remove the error message. The users can
> use the CAN error frames or the netstasts instead to see if lost messages occurred.
> 
> That said, I am OK with your proposed patch. See above comment as a simple FYI.

I'm up for both solutions :)

@Marc what would you prefer?

> 
> > Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
> > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> 
> Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> 
> 
> Yours sincerely,
> Vincent Mailhol
> 

/Sean