Re: [PATCH] bonding: Improve the accuracy of LACPDU transmissions

From: Seth Forshee
Date: Wed Jun 25 2025 - 12:07:20 EST


On Tue, Jun 24, 2025 at 05:47:13PM -0500, Seth Forshee wrote:
> As I understand it the intention is to ensure that LACPDU tx is spaced
> out by at least ~300ms, not to align them to an arbitrary ~300ms
> boundary. If so, a simple improvement would be to reset the counter only
> when an LACPDU is sent, then allow sending a LACPDU any time after it
> reaches zero. Though I still think it makes sense to make the state
> machines time-based rather than counter-based to ensure they aren't
> sensitive to delays in running the delayed work.

Sent a patch which only changes when the counter is reset:

https://lore.kernel.org/all/20250625-fix-lacpdu-jitter-v1-1-4d0ee627e1ba@xxxxxxxxxx/

On an unloaded system the timing of LACPDUs is consistent within ~10ms
after this change.