Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation

From: Markus Elfring
Date: Tue Jun 24 2025 - 15:22:14 EST


>> +++ b/drivers/net/can/usb/ucan.c
>> @@ -1353,16 +1353,14 @@ static int ucan_probe(struct usb_interface *intf,
>> ep = &iface_desc->endpoint[i].desc;
>>
>> if (((ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK) != 0) &&
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This is:
>
> usb_endpoint_dir_in(ep)

Can the check for a single value like “USB_DIR_IN” be really mapped to
an other value range?
https://elixir.bootlin.com/linux/v6.16-rc3/source/include/uapi/linux/usb/ch9.h#L495-L503

Regards,
Markus