Re: [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform

From: Jacek Kowalski
Date: Tue Jun 24 2025 - 14:35:09 EST


You are comparing the wrong value with NVM_SUM_FACTORY_DEFAULT. You should check it against the checksum word 0x3F (NVM bytes 0x7E and
0x7F) which is used to ensure that the base NVM image is a valid
image, and which in my case is left unchanged by Dell in the firmware.

You are right that I'm comparing the wrong value. But it is only a matter of variable name:

- if (hw->mac.type == e1000_pch_tgp && checksum ==
(u16)NVM_SUM_FACTORY_DEFAULT) {
+ if (hw->mac.type == e1000_pch_tgp && nvm_data ==
(u16)NVM_SUM_FACTORY_DEFAULT) {

Could you check my change with this modification?

--
Best regards,
Jacek Kowalski