Re: [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform

[Jacek Kowalski]

> > > > +	if (hw->mac.type == e1000_pch_tgp && checksum == 
> > > > (u16)NVM_SUM_FACTORY_DEFAULT) {
> > >
> > > I see that a similar cast is applied to NVM_SUM. But why? If 
> > > it's not necessary then I would advocate dropping it.
> >
> > It's like that since the beginning of git history, tracing back to
> > e1000(...)
> >
> > I'd really prefer to keep it as-is here for a moment, since 
> > similar constructs are not only here, and then clean them up 
> > separately.
>
> Ok. But can we look into cleaning this up as a follow-up?

Sure, I'll prepare the patch and send it once this series is applied.

--
Best regards,
  Jacek Kowalski