RE: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record

[Shiju Jose]

>-----Original Message-----
>From: Li Ming <ming.li@xxxxxxxxxxxx>
>Sent: 20 June 2025 06:29
>To: dave@xxxxxxxxxxxx; Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>;
>dave.jiang@xxxxxxxxx; alison.schofield@xxxxxxxxx; vishal.l.verma@xxxxxxxxx;
>ira.weiny@xxxxxxxxx; dan.j.williams@xxxxxxxxx; Shiju Jose
><shiju.jose@xxxxxxxxxx>
>Cc: linux-cxl@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Li Ming
><ming.li@xxxxxxxxxxxx>
>Subject: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event
>record
>
>cxl_find_rec_dram() is used to find a DRAM event record based on the inputted
>attributes. Different repair_type of the inputted attributes will check the DRAM
>event record in different ways.
>When EDAC driver is performing a memory rank sparing, it should use
>CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
>event record checking.
>
>Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing
>control feature")
>Signed-off-by: Li Ming <ming.li@xxxxxxxxxxxx>
>---
>base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes

Reviewed-by: Shiju Jose <shiju.jose@xxxxxxxxxx>
>---
> drivers/cxl/core/edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c index
>d725ee954199..623aaa4439c4 100644
>--- a/drivers/cxl/core/edac.c
>+++ b/drivers/cxl/core/edac.c
>@@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
> 		attrbs.bank = ctx->bank;
> 	break;
> 	case EDAC_REPAIR_RANK_SPARING:
>-		attrbs.repair_type = CXL_BANK_SPARING;
>+		attrbs.repair_type = CXL_RANK_SPARING;
> 		break;
> 	default:
> 		return NULL;
>--
>2.34.1