Re: [PATCH] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo

[Abdelrahman Fekry]

On Tue, Jun 24, 2025 at 4:25 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jun 24, 2025 at 04:08:41PM +0300, Abdelrahman Fekry wrote:
> > The sysfs attributes active_bo and free_bo expose internal buffer
> > state used only for debugging purposes. These are not part of
> > any standard kernel ABI and needs to be removed before this
> > driver can be moved out of drivers/staging.
> >
> > - Remove active_bo and free_bo attributes
> > - Remove group registration calls form hmm_init() and hmm_cleanup()
>
> Suggested-by: ?
>
> ...
>
> > +     /* Removed sysfs group registration for active_bo and free_bo attributes */
>
> > +
> > +     /* Removed sysfs group remove for active_bo and free_bo attributes */
>
> These comments do not bring a value, no need to have them.
>
noted , thank you will send v2
> With the above fixed,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>