Re: [PATCH net-next v1 1/1] net: usb: lan78xx: annotate checksum assignment to silence sparse warnings

From: Simon Horman
Date: Tue Jun 24 2025 - 06:47:58 EST


On Mon, Jun 23, 2025 at 04:49:13PM -0700, Jakub Kicinski wrote:
> On Fri, 20 Jun 2025 10:46:18 +0200 Oleksij Rempel wrote:
> > - skb->csum = ntohs((u16)(rx_cmd_b >> RX_CMD_B_CSUM_SHIFT_));
> > + __be16 csum_raw;
> > +
> > + csum_raw = (__force __be16)(rx_cmd_b >> RX_CMD_B_CSUM_SHIFT_);
> > + skb->csum = (__force __wsum)ntohs(csum_raw);
>
> You can avoid the __force __be16 if you switch the variable to be u16
> and then htons instead of ntohs

Ok, now I am confused.
What is the endian of these integers?