Re: [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message

[Randy Dunlap]

On 6/22/25 11:40 PM, Alok Tiwari wrote:
> Corrected the error log to print ctrl->io_cqes instead of
> incorrectly using ctrl->io_sqes for the io cqes size check.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>  drivers/nvme/target/pci-epf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
> index a4295a5b8d280..44288d8f5aa11 100644
> --- a/drivers/nvme/target/pci-epf.c
> +++ b/drivers/nvme/target/pci-epf.c
> @@ -1860,7 +1860,7 @@ static int nvmet_pci_epf_enable_ctrl(struct nvmet_pci_epf_ctrl *ctrl)
>  	ctrl->io_cqes = 1UL << nvmet_cc_iocqes(ctrl->cc);
>  	if (ctrl->io_cqes < sizeof(struct nvme_completion)) {
>  		dev_err(ctrl->dev, "Unsupported I/O CQES %zu (need %zu)\n",
> -			ctrl->io_sqes, sizeof(struct nvme_completion));
> +			ctrl->io_cqes, sizeof(struct nvme_completion));
>  		goto err;
>  	}
>  

-- 
~Randy