Re: [RFC 1/2] lib/vsprintf: Add support for pte_t

[Andy Shevchenko]

On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote:
> Add a new format for printing page table entries.

> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: linux-doc@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-mm@xxxxxxxxx

Please. move these to be after the '---' cutter line below. Just leave SoB tag
alone. This will have the same effect w/o polluting commit message.

> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> ---

(somewhere here is a good place for all your Cc: tags)

...

> +        %ppte

I believe you can take %pte.

...

> +Print standard page table entry pte_t.
> +
> +Passed by reference.
> +
> +Examples for a 64 bit page table entry, given &(u64)0xc0ffee::

What does this mean?

> +        %ppte   0x00c0ffee

Can it be ever 64-bit?

...

> +			spec.field_width = 10;
> +			spec.precision = 8;
> +			spec.base = 16;
> +			spec.flags = SPECIAL | SMALL | ZEROPAD;

Do not duplicate code we have already in the file.

> +			if (sizeof(pte_t) == sizeof(u64)) {
> +				u64 val = pte_val(*pte);
> +
> +				return number(buf, end, val, spec);
> +			}

Ditto.

> +			WARN_ONCE(1, "Non standard pte_t\n");

(almost) Ditto,

> +			return error_string(buf, end, "(einval)", spec);

Ditto.

> +		}
> +		fallthrough;

Please, avoid this, it makes code much harder to read and maintain.
See above how.

-- 
With Best Regards,
Andy Shevchenko