Re: [PATCH v1 1/2] ARM: dts: stm32: add support of stm32mp157f-dk2 board

[Alexandre TORGUE]

Hi Himanshu

On 5/27/25 08:36, Himanshu Bhavani wrote:
> Hi Alexandre,
>
> > Hi Himanshu
> >
> > On 5/24/25 12:03, Himanshu Bhavani wrote:
> > > STM32MP157F is similar to the STM32MP157C, so reuse the existing
> > > stm32mp157c-dk2.dts as a base for the STM32MP157F-DK2 board.
> > >
> > > Datasheet: https://www.st.com/resource/en/data_brief/stm32mp157f-dk2.pdf
> > > Signed-off-by: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>
> > > ---
> > >     arch/arm/boot/dts/st/Makefile            |  3 ++-
> > >     arch/arm/boot/dts/st/stm32mp157f-dk2.dts | 15 +++++++++++++++
> > >     2 files changed, 17 insertions(+), 1 deletion(-)
> > >     create mode 100644 arch/arm/boot/dts/st/stm32mp157f-dk2.dts
> > >
> > > diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
> > > index 60d55516f723..38179638e5eb 100644
> > > --- a/arch/arm/boot/dts/st/Makefile
> > > +++ b/arch/arm/boot/dts/st/Makefile
> > > @@ -70,7 +70,8 @@ dtb-$(CONFIG_ARCH_STM32) += \
> > >         stm32mp157c-lxa-tac-gen2.dtb \
> > >         stm32mp157c-odyssey.dtb \
> > >         stm32mp157c-osd32mp1-red.dtb \
> > > -     stm32mp157c-phycore-stm32mp1-3.dtb
> > > +     stm32mp157c-phycore-stm32mp1-3.dtb \
> > > +     stm32mp157f-dk2.dtb
> > >     dtb-$(CONFIG_ARCH_U8500) += \
> > >         ste-snowball.dtb \
> > >         ste-hrefprev60-stuib.dtb \
> > > diff --git a/arch/arm/boot/dts/st/stm32mp157f-dk2.dts b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts
> > > new file mode 100644
> > > index 000000000000..ab406b2c44c1
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts
> > > @@ -0,0 +1,15 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> > > +/*
> > > + * Copyright (C) 2025 Silicon Signals Pvt. Ltd.
> > > + *
> > > + * Author: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "stm32mp157c-dk2.dts"
> >
> > In this case what is the aim of this series if you just use stm32mp157C
> > devicetree ?
>
> This patch series aims to add support for the STM32MP157F board device
> tree. The primary motivation is to ensure that users working with the
> STM32MP157F variant have a reference DTS available. Currently, no such
> device tree exists, even though the STM32MP157F and STM32MP157C are
> largely similar.
>
> > ST people (mainly Amélie) are preparing a full support of
> > STM32MP157F-DK2 leveraging the F variant compare to the C variant.
> > Series will be sent this week.
>
> If ST is working on a dedicated DTS for the F variant, it's likely they are starting
> from the C variant as a base, this is exactly the approach I’ve taken here. At this
> stage, I have not included an SCMI-based version of the board since it hasn't
> been tested yet.

Please have a look on:

https://lore.kernel.org/all/20250527-stm32mp157f-dk2-v1-0-8aef885a4928@xxxxxxxxxxx/

The idea is to have the same approach than for STM32MP13 and STM32MP25 
relying on SCMI and preparing the add of F variant feature: DVFS/cpufreq.

regards
alex


> Please let me know if you have any further suggestions.
>
>
> Best Regards,
> Himanshu
>
> > Regards
> > Alex
> >
> > > +
> > > +/ {
> > > +     model = "STMicroelectronics STM32MP157F-DK2 Discovery Board";
> > > +     compatible = "st,stm32mp157f-dk2", "st,stm32mp157";
> > > +};