Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

[George Moussalem]

Hi Konrad,

On 5/27/25 14:59, Konrad Dybcio wrote:
> On 5/26/25 2:55 PM, Krzysztof Kozlowski wrote:
> > On 26/05/2025 08:43, George Moussalem wrote:
> > > > > +  qca,dac:
> > > > > +    description:
> > > > > +      Values for MDAC and EDAC to adjust amplitude, bias current settings,
> > > > > +      and error detection and correction algorithm. Only set in a PHY to PHY
> > > > > +      link architecture to accommodate for short cable length.
> > > > > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > > > > +    items:
> > > > > +      - items:
> > > > > +          - description: value for MDAC. Expected 0x10, if set
> > > > > +          - description: value for EDAC. Expected 0x10, if set
> > > >
> > > > If this is fixed to 0x10, then this is fully deducible from compatible.
> > > > Drop entire property.
> > >
> > > as mentioned to Andrew, I can move the required values to the driver
> > > itself, but a property would still be required to indicate that this PHY
> > > is connected to an external PHY (ex. qca8337 switch). In that case, the
> > > values need to be set. Otherwise, not..
> > >
> > > Would qcom,phy-to-phy-dac (boolean) do?
> >
> > Seems fine to me.
>
> Can the driver instead check for a phy reference?

Do you mean using the existing phy-handle DT property or create a new DT 
property called 'qcom,phy-reference'? Either way, can add it for v2.

> Konrad

Best regards,
George