Re: [PATCH 11/23] md/md-bitmap: make method bitmap_ops->daemon_work optional

[Yu Kuai]

Hi,

在 2025/05/27 14:19, Hannes Reinecke 写道:
> On 5/24/25 08:13, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@xxxxxxxxxx>
> >
> > daemon_work() will be called by daemon thread, on the one hand, daemon
> > thread doesn't have strict wake-up time; on the other hand, too much
> > work are put to daemon thread, like handle sync IO, handle failed
> > or specail normal IO, handle recovery, and so on. Hence daemon thread
> > may be too busy to clear dirty bits in time.
> >
> > Make bitmap_ops->daemon_work() optional and following patches will use
> > separate async work to clear dirty bits for the new bitmap.
> Why not move it to a workqueue in general?
> The above argument is valid even for the current implementation, no?

Yes, and however, I'll prefer not to touch current implementaion :(
This is trivial comparing to other flaws like global spinlock.

Thanks,
Kuai

> Cheers,
>
> Hannes