Re: [PATCH v1 2/2] arm64: dts: qcom: qcs9075-evk: Add sound card

[Mohammad Rafi Shaik]

On 5/25/2025 10:43 PM, Dmitry Baryshkov wrote:
> On 25/05/2025 18:53, Mohammad Rafi Shaik wrote:
> > Add the sound card node with tested playback over max98357a
> > i2s speakers and i2s mic.
>
> I2S
>
> speaker amplifier

Ack, will update in next patch version
> > Introduce HS (High-Speed) MI2S pin control support.
> > The I2S max98357a speaker is connected via HS0 and I2S
>
> speaker amplifier

Ack

> > microphones utilize the HS2 interface.
> >
> > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> > ---
> >   .../boot/dts/qcom/qcs9075-iq-9075-evk.dts     | 52 +++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/sa8775p.dtsi         | 14 +++++
> >   2 files changed, 66 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/ 
> > arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> > index 0e44e0e6dbd4..1ebf42b0b10e 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> > @@ -6,6 +6,7 @@
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > +#include <dt-bindings/sound/qcom,q6afe.h>
> >   #include "qcs9075-som.dtsi"
> > @@ -20,6 +21,57 @@ aliases {
> >       chosen {
> >           stdout-path = "serial0:115200n8";
> >       };
> > +
> > +    max98357a: audio-codec-0 {
> > +        compatible = "maxim,max98357a";
> > +        #sound-dai-cells = <0>;
> > +    };
> > +
> > +    dmic_codec: dmic-codec {
>
> Just dmic or audio-codec-1

Ack,

Yes right, should be audio-codec-1

will update in next version.
> > +        compatible = "dmic-codec";
> > +        #sound-dai-cells = <0>;
> > +        num-channels = <1>;
> > +    };
> > +
> > +    sound {
> > +        compatible = "qcom,qcs9075-sndcard";
> > +        model = "qcs9075-rb8-snd-card";
>
> Were the bindings and the driver sent? Cover letter doesn't mention 
> them. It is better to send them as a single patch series (this is the 
> case for all subsys except net-next and trees maintained by Greg, e.g. 
> USB).

https://lore.kernel.org/linux-sound/174773911882.44858.10139663344496764867.b4-ty@xxxxxxxxxx/

The Bindings and driver compatible change is already merged, Will add 
patch link in next version cover-letter.

Thanks & Regards,
Mohammad Rafi Shaik

> +
> > +        pinctrl-0 = <&hs0_mi2s_active>, <&hs2_mi2s_active>;
> > +        pinctrl-names = "default";
> > +
> > +        hs0-mi2s-playback-dai-link {
> > +            link-name = "HS0 mi2s playback";
> > +
> > +            codec {
> > +                sound-dai = <&max98357a>;
> > +            };
> > +
> > +            cpu {
> > +                sound-dai = <&q6apmbedai PRIMARY_MI2S_RX>;
> > +            };
> > +
> > +            platform {
> > +                sound-dai = <&q6apm>;
> > +            };
> > +        };
> > +
> > +        hs2-mi2s-capture-dai-link {
> > +            link-name = "HS2 mi2s capture";
> > +
> > +            codec {
> > +                sound-dai = <&dmic_codec>;
> > +            };
> > +
> > +            cpu {
> > +                sound-dai = <&q6apmbedai TERTIARY_MI2S_TX>;
> > +            };
> > +
> > +            platform {
> > +                sound-dai = <&q6apm>;
> > +            };
> > +        };
> > +    };
> >   };