Re: [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting

[Bagas Sanjaya]

On 5/26/25 19:48, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:
>
> > On Mon, May 26, 2025 at 02:14:43AM +0100, George Anthony Vernon wrote:
> > > Make small grammar fixes to Amiga joystick documentation.
> > >
> > > Also make heading adornments compliant with the guidelines to improve
> > > organisation of the page.
> >
> > Split up these two changes into separate patches.
>
> The word "also" in a changelog is indeed a hint that a patch is doing
> too many things.
>
> For a simple patch like this, though, I would not force a resend just
> for that.

Do you mean keeping the patch as-is?

> > > -~~~~~~~~~~~~~~~~~~~~~~~~~
> > > -Amiga joystick extensions
> > > -~~~~~~~~~~~~~~~~~~~~~~~~~
> > > +===============
> > > +Amiga joysticks
> > > +===============
> >
> > I would prefer to keep section adornments in this doc as-is, though.
>
> ...and why...?  We have a standard progression, why not use it?

I'm leaning towards following doc-specific convention (i.e. on this
doc). I could adapt to it, but some time later when I re-read the
source I might be semantically confused.

Thanks.

--
An old man doll... just what I always wanted! - Clara