Re: [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support

[George Moussalem]

Hi Andrew,

On 5/25/25 23:42, Andrew Lunn wrote:
> > +	phy_write_mmd(phydev, MDIO_MMD_PCS, IPQ5018_PHY_MMD3_AZ_CTRL1,
> > +		      IPQ5018_PHY_MMD3_AZ_CTRL1_VAL);
>
> Using MMD3 in the name is a good idea, but PCS would be better. Not
> everybody knows MDIO_MMD_PCS == 3.

Will rename all IPQ5018_PHY_MMD3* macros to IPQ5018_PHY_PCS* in next 
version.

> 	
>      Andrew
>
> ---
> pw-bot: cr

Thanks,
George