Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version
From: Krzysztof Kozlowski
Date: Tue May 20 2025 - 02:06:41 EST
On 30/04/2025 10:33, Krzysztof Kozlowski wrote:
> On 30/04/2025 10:30, Bryan O'Donoghue wrote:
>> On 30/04/2025 09:19, Krzysztof Kozlowski wrote:
>>> If anyone wants to know it and cannot deduce from compatible, then add
>>> debugfs interface.
>>
>> dev_dbg(); isn't too offensive really IMO but if it really bothers you
>> switching to debugfs would be fine.
>
> Yes, please. Dmesg should be only contain issues or some useful
> debugging data. Probe success is not useful. It duplicates sysfs and
> tracing. Version of hardware - well, I am sure it duplicates the compatible.
To recall: kernel coding style is also clear here:
"When drivers are working properly they are quiet,"
and kernel debugging guide as well:
"In almost all cases the debug statements shouldn't be upstreamed, as a
working driver is supposed to be silent."
So I really do not get why this driver deserved exception. Nevertheless
I think we agreed that these logs can go away, thus I just sent a v2
with a bit extended commit msg.
Best regards,
Krzysztof