Re: [PATCH V3 0/2] sched: Align uclamp and util_est

[Xuewen Yan]

Gentle ping if forgotten.

Sorry to ask, but may I know if this patch can be merged into the mainline?

Thanks!

On Tue, Apr 22, 2025 at 11:27 PM Dietmar Eggemann
<dietmar.eggemann@xxxxxxx> wrote:
>
> On 17/04/2025 06:34, Xuewen Yan wrote:
> > Now, both uclamp and util_est have been adapted for DELAYED_DEQUEUE,
> > and the double enqueue/dequeue issue no longer exists.
> > However, there is still room for optimization in both uclamp and util_est.
> > Previous discussions as following:
> > https://lore.kernel.org/all/CAB8ipk8pEvOtCm-d0o1rsekwxPWUHk9iBGtt9TLTWW-iWTQKiA@xxxxxxxxxxxxxx/
> > https://lore.kernel.org/all/84441660bef0a5e67fd09dc3787178d0276dad31.1740664400.git.hongyan.xia2@xxxxxxx/T/#u
> > https://lore.kernel.org/all/CAB8ipk9LpbiUDnbcV6+59+Sa=Ai7tFzO===mpLD3obNdV4=J-A@xxxxxxxxxxxxxx/T/#u
> > https://lore.kernel.org/all/aa8baf67-a8ec-4ad8-a6a8-afdcd7036771@xxxxxxx/
> > https://lore.kernel.org/all/20250325014733.18405-1-xuewen.yan@xxxxxxxxxx/
> >
> > patch[1]: Simply the condition for util_est_dequeue/enqueue;
> > patch[2] aligns uclamp and util_est and call before freq update to improve
> > the performance and power.
> >
> > Xuewen Yan (2):
> >   sched/util_est: Simply the condition for util_est_dequeue/enqueue
> >   sched/uclamp: Align uclamp and util_est and call before freq update
> >
> >  kernel/sched/core.c | 17 ++++++++++-------
> >  kernel/sched/fair.c |  4 ++--
> >  2 files changed, 12 insertions(+), 9 deletions(-)
> >
> > ---
> > v3:
> > - split previous patch in 2 patches.
> >
> > v2:
> > - simply the util-est's en/dequeue check;
> > ---
>
> LGTM.
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Tested-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
>
> I assume you can add Hongyan's test tag from:
> https://lkml.kernel.org/r/be0cace9-d173-4de3-959e-861876ad77fc@xxxxxxx
> as well.
>