Re: [PATCH] net: dwmac-sun8i: Use parsed internal PHY address instead of 1
From: Andrew Lunn
Date: Mon May 19 2025 - 16:38:44 EST
> There's actually only two users of this (this code path for internal PHYs is
> only used by two chips), which are platform dtsi files that have the address
> already set to 1.
>
> I have actually tested both with hardware and they work fine.
O.K.
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
This is something to think about for patches in general. What
questions are reviewers likely to ask, and can you answer them in the
commit message?
Andrew