Re: [PATCH v1 1/2] ethernet: eswin: Document for eic7700 SoC

From: Andrew Lunn
Date: Sun May 18 2025 - 18:38:34 EST


> + phy-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [mii, gmii, rgmii, rmii, sgmii]

In theory, all four rgmii modes should be listed. In practice, only
rgmii-id is likely to be used.

> +examples:
> + - |
> + gmac0: ethernet@50400000 {
> + compatible = "eswin,eic7700-qos-eth";
> + reg = <0x0 0x50400000 0x0 0x10000>;
> + interrupt-parent = <&plic>;
> + interrupt-names = "macirq";
> + interrupts = <61>;
> + phy-mode = "rgmii";

Please don't use rgmii in an example. It is probably wrong, unless you
have an unusual PCB design.

Andrew