Re: [PATCH] HID: lenovo: Unbreak USB/BT keyboards on non-ACPI platforms

[Janne Grunau]

Hej,

On Sun, May 18, 2025 at 07:46:12PM +0200, Armin Wolf wrote:
> Am 18.05.25 um 11:43 schrieb Janne Grunau:
> 
> >>   
> >>   static void __exit platform_profile_exit(void)
> >>   {
> >> -	sysfs_remove_group(acpi_kobj, &platform_profile_group);
> >> +	if (acpi_kobj)
> >> +		sysfs_remove_group(acpi_kobj, &platform_profile_group);
> >> +
> >>   	class_unregister(&platform_profile_class);
> >>   }
> >>   module_init(platform_profile_init);
> > thanks, patch works on the affected system and the HID device for the
> > Lenovo keyboard probes successfully. We still need to stub
> > platform_profile_cycle() to get rid of the ACPI Kconfig dependency. I'll
> > send that out separately.
> >
> > Reviewed-by: Janne Grunau <j@xxxxxxxxxx>
> > Tested-by: Janne Grunau <j@xxxxxxxxxx>
> >
> Alright, i will send this patch to the ACPI mailing list ASAP. Please keep in mind
> that merely stubbing out the affected functions is not enough, as the platform profile code
> needs to be moved out of drivers/acpi/ as well.

Thanks. I will go with patch which #ifdefs the platform_profile_cycle()
call out. It is only used for a special detachable tablet keyboard which
is ACPI enabled device anyway. So it will be hid-lenovo local change.

Janne