Re: [PATCH net-next v4 0/4] net: selftest: improve test string formatting and checksum handling

From: Jakub Kicinski
Date: Fri May 16 2025 - 21:45:22 EST


On Thu, 15 May 2025 10:30:56 +0200 Oleksij Rempel wrote:
> - Inconsistent checksum behavior: On DSA setups and similar
> environments, checksum offloading is not always available or
> appropriate. The previous selftests did not distinguish between software
> and hardware checksum modes, leading to unreliable results. This
> patchset introduces explicit csum_mode handling and adds separate tests
> for both software and hardware checksum validation.

What device are you talking about? How is this a problem with
the selftest and not with the stack? If the test is flaky I'd
think real traffic will suffer too. We pass these selftest packets
thru xmit validation AFAICT, so the stack should compute checksum
for the if the device can't.