Re: [PATCH v1 net] net: lan743x: Restore SGMII CTRL register on resume

From: Jakub Kicinski
Date: Fri May 16 2025 - 19:40:23 EST


On Fri, 16 May 2025 09:27:19 +0530 Thangaraj Samynathan wrote:
> SGMII_CTRL register, which specifies the active interface, was not
> properly restored when resuming from suspend. This led to incorrect
> interface selection after resume particularly in scenarios involving
> the FPGA.
>
> To fix this:
> - Move the SGMII_CTRL setup out of the probe function.
> - Initialize the register in the hardware initialization helper function,
> which is called during both device initialization and resume.
>
> This ensures the interface configuration is consistently restored after
> suspend/resume cycles.

Is there a reason you're not CCing Raju Lakkaraju on this?
Having a review tag from the author of the change under Fixes
is always great.