Re: [PATCH v5] bus: mhi: host: don't free bhie tables during suspend/hibernation

[Jeff Hugo]

On 5/16/2025 12:42 PM, Muhammad Usama Anjum wrote:
> On 5/16/25 7:59 PM, Jeff Hugo wrote:
> > On 5/14/2025 2:14 AM, Muhammad Usama Anjum wrote:
> > > Fix dma_direct_alloc() failure at resume time during bhie_table
> > > allocation because of memory pressure. There is a report where at
> > > resume time, the memory from the dma doesn't get allocated and MHI
> > > fails to re-initialize.
> > >
> > > To fix it, don't free the memory at power down during suspend /
> > > hibernation. Instead, use the same allocated memory again after every
> > > resume / hibernation. This patch has been tested with resume and
> > > hibernation both.
> > >
> > > There are two allocations of bhie; rddm and fbc. Optimize both of those
> >
> > There are 3, but you touch 2.  I just commented on this in v4.  Only
> > touching two is fine (the device for the 3rd one doesn't need this), but
> > the documentation must be accurate.
> Yeah, for 3rd one in mhi_load_image_bhie(), this optimization isn't
> needed. Let me rephrase and resent v6.
>
> > > allocations. The rddm is of constant size for a given hardware. While
> > > the fbc_image size depends on the firmware. If the firmware changes,
> > > we'll free and allocate new memory for it. This patch is moticated from
> >
> > moticated?  Motivated maybe?
> I'm using checkpatch --strict --codespell and hopping that it'll catch
> typos. But it misses some of them. Do you use any such tool?

I use the same. Codespell is nice, but doesn't catch everything.

-Jeff