Re: [PATCH 2/7] Docu: PCI: Update pcim_enable_device()

[Philipp Stanner]

On Fri, 2025-05-16 at 22:28 +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> [...]
> > > > pcim_enable_device() is not related anymore to switching the
> > > > mode
> > > > of
> > > > operation of any functions. It merely sets up a devres callback
> > > > for
> > > > automatically disabling the PCI device on driver detach.
> > > > 
> > > > Adjust the function's documentation.
> > > 
> > > Is the "Docu" prefix in thew Subject aligned with the git history
> > > of
> > > this file?
> > > 
> > 
> > Seems its "Documentation: ". Can fix.
> 
> Has Andy been sending his review off-list?  Or something is broken on
> my
> side...

Nope, it's on-list. Andy's a veteran ;-)

https://lore.kernel.org/linux-pci/aCXnPHy5heHCKVd_@xxxxxxxxxxxxxxxxxx/


> 
> Philipp, if you have a v2 ready, then I would love to pull it, while
> we
> await for more reviews, just to get enough soak time and allow for
> the
> 0-day and KernelCI to run their usual tests, etc.
> 
> Thank you!

I don't have it ready, but should be trivial to do, since it's not
fundamental critcism. I'll do my best.

P.

> 
> 	Krzysztof