Re: [PATCH 3/4] fs/buffer: remove superfluous statements
From: Jan Kara
Date: Fri May 16 2025 - 06:14:24 EST
On Thu 15-05-25 10:39:24, Davidlohr Bueso wrote:
> Get rid of those unnecessary return statements.
>
> Signed-off-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Sure. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/buffer.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index b02cced96529..210b43574a10 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -297,7 +297,6 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate)
>
> still_busy:
> spin_unlock_irqrestore(&first->b_uptodate_lock, flags);
> - return;
> }
>
> struct postprocess_bh_ctx {
> @@ -422,7 +421,6 @@ static void end_buffer_async_write(struct buffer_head *bh, int uptodate)
>
> still_busy:
> spin_unlock_irqrestore(&first->b_uptodate_lock, flags);
> - return;
> }
>
> /*
> @@ -1684,7 +1682,6 @@ void block_invalidate_folio(struct folio *folio, size_t offset, size_t length)
> filemap_release_folio(folio, 0);
> out:
> folio_clear_mappedtodisk(folio);
> - return;
> }
> EXPORT_SYMBOL(block_invalidate_folio);
>
> --
> 2.39.5
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR