Re: [PATCH v8 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute
From: Andy Shevchenko
Date: Fri May 16 2025 - 05:38:47 EST
On Thu, May 15, 2025 at 06:14:33PM -0300, Jonathan Santos wrote:
> Ad7768-1 has a different -3db frequency multiplier depending on
> the filter type configured. The cutoff frequency also varies according
> to the current ODR.
>
> Add a readonly low pass -3dB frequency cutoff attribute to clarify to
> the user which bandwidth is being allowed depending on the filter
> configurations.
...
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
> - BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY),
You can make the diff looking better and easier to review if squeeze the new
bit in between of the existing one, this will remove +- LoC here.
--
With Best Regards,
Andy Shevchenko