Re: [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h

From: Andy Shevchenko
Date: Fri May 16 2025 - 05:17:49 EST


On Thu, May 15, 2025 at 03:37:06PM +0200, Philipp Stanner wrote:
> On Thu, 2025-05-15 at 16:02 +0300, Andy Shevchenko wrote:
> > On Thu, May 15, 2025 at 02:46:04PM +0200, Philipp Stanner wrote:
> > > pcim_intx() once was an internal PCI function, but since then has
> > > been
> > > published and is used by drivers, and, therefore, available in
> > > include/linux/pci.h. The function is not used within PCI anymore.
> > >
> > > Remove pcim_intx()'s prototype from drivers/pci/pci.h
> >
> > Can this be moved up in the series? Or is there other dependencies?
> > I.o.w. this
> > looks like a leftover from something of the previous work.
>
> That can be moved to anywhere, including a separate patch. It's an
> independent patch, a leftover from last year. But it's related to
> devres, because it was also added because of the problem with
> pcim_enable_device().

When put at the end of the series it makes an illusion that there are
dependencies. Separate patch is ideal, being first is good enough to me.

--
With Best Regards,
Andy Shevchenko