Re: [PATCH v4 14/23] iommufd: Add mmap interface

[Nicolin Chen]

On Thu, May 08, 2025 at 08:02:35PM -0700, Nicolin Chen wrote:
> +int _iommufd_alloc_mmap(struct iommufd_ctx *ictx, struct iommufd_object *owner,
> +			phys_addr_t base, size_t length, unsigned long *offset)
> +{
...
> +	int num_pfns, rc;
...
> +	num_pfns = length >> PAGE_SHIFT;

I forgot to clean away this num_pfns, as "length >> PAGE_SHIFT"
stores to immap->num_pfns already.

Will drop this in v5.

Thanks
Nicolin