Re: [RFC PATCH] ASoC: intel/sdw_utils: Assign initial value in asoc_sdw_rt_amp_spk_rtd_init()

From: Liao, Bard
Date: Mon May 05 2025 - 08:58:57 EST




On 5/5/2025 8:46 PM, I Hsin Cheng wrote:
> On Mon, May 05, 2025 at 04:27:04PM +0800, Liao, Bard wrote:

>
> Hi,
>
> Thanks for your kindly review!
>
>> The existing name_prefix is with either "-1" or "-2". But we can't make
>> the assumption in the asoc_sdw_rt_amp_spk_rtd_init() helper. We might
>> have "-3", "-4" etc in the future.
>>
> I get it, so in that case we should stick with current implementation
> then. For "ret"'s initial value, do you think "-EINVAL" is ok or do you
> prefer other value to be used ?

-EINVAL is good to me.

> I'll refine commit message and send a formal v2 patch with your
> preference.
>
> Best regards,
> I Hsin Cheng
>