Re: [PATCH v2 2/3] dt-bindings: iio: adc: mcp3911: add reset-gpios

[Jonathan Cameron]

On Mon, 28 Apr 2025 17:40:38 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Mon, Apr 28, 2025 at 08:54:12AM +0200, Marcus Folkesson wrote:
> > The MCP391X family provides an active low reset signal that is still not
> > described in the bindings.
> > 
> > Add reset-gpios to the bindings and the example.
> > 
> > Co-developed-by: Lukas Rauber <lukas.rauber@xxxxxxxxxx>
> > Signed-off-by: Lukas Rauber <lukas.rauber@xxxxxxxxxx>
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>  
> 
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Just for reference this also had an ack from Krzysztof on v1 which
raced with this version being posted.

b4 found both and confused me :)

Jonathan

> 
> > ---
> >  Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
> > index 06951ec5f5da381a9bb942d0ac7416128eebd3bc..3a69ec60edb915ae16312b94fddd32f5c87f37a7 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
> > @@ -32,6 +32,9 @@ properties:
> >    spi-max-frequency:
> >      maximum: 20000000
> >  
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> >    clocks:
> >      description: |
> >        Phandle and clock identifier for external sampling clock.
> > @@ -71,6 +74,7 @@ unevaluatedProperties: false
> >  
> >  examples:
> >    - |
> > +    #include <dt-bindings/gpio/gpio.h>
> >      spi {
> >        #address-cells = <1>;
> >        #size-cells = <0>;
> > @@ -80,6 +84,7 @@ examples:
> >          reg = <0>;
> >          interrupt-parent = <&gpio5>;
> >          interrupts = <15 2>;
> > +        reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
> >          spi-max-frequency = <20000000>;
> >          microchip,device-addr = <0>;
> >          vref-supply = <&vref_reg>;
> > 
> > -- 
> > 2.49.0
> >