Re: [PATCH v2 1/5] Documentation: ABI: add oversampling frequency in sysfs-bus-iio

[Jonathan Cameron]

On Wed, 30 Apr 2025 01:03:07 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Apr 29, 2025 at 6:40 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> >
> > On 4/29/25 8:47 AM, Jorge Marques wrote:  
> > >
> > > Hi Andy,
> > >
> > > I agree with your suggestion, and in this case the appropriate kernel
> > > version is 3.10.
> > >  
> > >>  
> > >>> +What:              /sys/bus/iio/devices/iio:deviceX/oversampling_frequency
> > >>> +KernelVersion:     6.15  
> > >>
> > >> Then why don't you put the real version of the first release that has it?
> > >>  
> > >>> +Contact:   linux-iio@xxxxxxxxxxxxxxx
> > >>> +Description:
> > >>> +           Some devices have internal clocks for oversampling.
> > >>> +           Sets the resulting frequency in Hz to trigger a conversion used by
> > >>> +           the oversampling filter.
> > >>> +           If the device has a fixed internal clock or is computed based on
> > >>> +           the sampling frequency parameter, the parameter is read only.
> > >>> +
> > >>> +What:              /sys/bus/iio/devices/iio:deviceX/oversampling_frequency_available
> > >>> +KernelVersion:     6.15  
> > >>
> > >> Ditto.
> > >>  
> > >>> +Contact:   linux-iio@xxxxxxxxxxxxxxx
> > >>> +Description:
> > >>> +           Hardware dependent values supported by the oversampling
> > >>> +           frequency.  
> >
> >
> > I don't see oversampling_frequency used in any existing driver, so how could
> > it be introduced in kernel 3.10? I think you confuse it with
> > events/sampling_frequency.
> >
> > oversampling_frequency is new and so 6.16 should be correct if Jonathan picks
> > this up in the next few weeks, otherwise it will be 6.17.  
> 
> If this is the case, the whole commit message should be revisited.
> 
Yeah. That last bit about the existing drivers is talking about unrelated
ABI.

Jonathan