Re: [PATCH v2 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

From: Jonathan Cameron
Date: Mon May 05 2025 - 08:38:27 EST


On Mon, 5 May 2025 13:33:16 +0200
Angelo Dureghello <adureghello@xxxxxxxxxxxx> wrote:

> Hi Jonathan,
>
> asking info about this patch.
>
> As explained, would not do anything else here, please let me know if it can
> be accepted or how to proceed.
I've queued up patch 1 as a fix. Patch 2 will need to wait on that.

>
> Thanks a lot,
> angelo
>
> On 09.04.2025 14:57, Nuno Sá wrote:
> > On Wed, 2025-04-09 at 11:16 +0200, Angelo Dureghello wrote:
> > > This patchset is intended to fix a random wrong chip ID read, or a
> > > scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The
> > > bus "read" operation must always check for busy flag before reading.
> > >
> > > First patch reorganizes a bit the busy-wait polling code, second patch
> > > fixes the wrong bus read occurence.
> > >
> > > NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be
> > > applied after the linked "ramp generator" patch.
> > >
> > > Link:
> > > https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@xxxxxxxxxxxx
> > > Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> > > ---
> >
> > LGTM,
> >
> > Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> >
> > > Changes in v2:
> > > - invert patch order, fix first.
> > > - Link to v1:
> > > https://lore.kernel.org/r/20250408-ad3552r-fix-bus-read-v1-0-37add66aeb08@xxxxxxxxxxxx
> > >
> > > ---
> > > Angelo Dureghello (2):
> > >       iio: dac: adi-axi-dac: fix bus read
> > >       iio: dac: adi-axi-dac: use unique bus free check
> > >
> > >  drivers/iio/dac/adi-axi-dac.c | 40 +++++++++++++++++++++++++---------------
> > >  1 file changed, 25 insertions(+), 15 deletions(-)
> > > ---
> > > base-commit: 6fb85f14853ddde06d57030c753168402bf69cd9
> > > change-id: 20250408-ad3552r-fix-bus-read-1522622fbd2b
> > >
> > > Best regards,
>