Re: [PATCH v4 0/20] ratelimit: Reduce ratelimit's false-positive misses
From: Petr Mladek
Date: Mon May 05 2025 - 07:38:15 EST
On Tue 2025-04-29 18:05:00, Paul E. McKenney wrote:
> Hello!
>
> This v4 series replaces open-coded uses of the ratelimit_state structure
> with formal APIs, counts all rate-limit misses, replaces jiffies=0 special
> case with a flag, provides a ___ratelimit() trylock-failure fastpath to
> (almost) eliminate false-positive misses, simplifies the code, and adds
> a simple test.
>
> The key point of this series is the reduction of false-positive misses.
> More could be done to avoid open-coded access to the ->interval and
> ->burst fields, and to tighten up checking of user input for these fields,
> but those are jobs for later patches.
JFYI, the whole series looks good to me.
Best Regards,
Petr