Re: [PATCH v8 2/2] media: i2c: Add driver for ST VD56G3 camera sensor

[Sylvain Petinot]

Hi Sakari,

Le 05/05/2025 à 10:00, Sakari Ailus a écrit :
> Hi Sylvain,
>
> Thanks for the update.
>
> On Fri, May 02, 2025 at 10:18:49PM +0200, Sylvain Petinot wrote:
> > +static int vd56g3_check_csi_conf(struct vd56g3 *sensor,
> > +				 struct fwnode_handle *endpoint)
> > +{
> > +	struct v4l2_fwnode_endpoint ep = { .bus_type = V4L2_MBUS_CSI2_DPHY };
> > +	u32 phy_data_lanes[VD56G3_MAX_CSI_DATA_LANES] = { ~0, ~0 };
> > +	u8 n_lanes;
> > +	u64 frequency;
> > +	int p, l;
>
> unsigned int. There are more cases where you have a loop variable that
> doesn't need to be signed. Please address these in a follow-up patch.

Thanks for raising the point. I'll do that asap.

--
Sylvain