Re: [PATCH 1/6] dt-bindings: clock: qcom: Add CMN PLL support for IPQ5018 SoC

[Jie Luo]

On 5/4/2025 3:03 PM, George Moussalem wrote:
> > > +  qcom,cmn-pll-eth-enable:
> > > +    description: Register in TCSR to enable CMN PLL to ethernet
> > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > +    items:
> > > +        - description: phandle of TCSR syscon
> > > +        - description: offset of TCSR register to enable CMN PLL to 
> > > ethernet
> > > +
> >
> > This TCSR should not be a part of CMN PLL, it is the LDO controller for
> > the internal GEPHY in IPQ5018 SoC, which can be moved to a part of GEPHY
> > device.
>
> I'm preparing a patch for the ipq5018 GE PHY too so can move it there. 
> Can you confirm the uniphy isn't dependent on this too? There are boards 
> out there which don't use the GE PHY at all, so if the uniphy depends on 
> it for SGMII/SGMII+, this approach wouldn't work.

This TCSR only impacts the GEPHY, has no effect on UNIPHY (PCS).