Re: [PATCH v3 3/3] drivers/base : Rename register_memory_blocks_under_node() and remove context argument

From: Zi Yan
Date: Sat May 03 2025 - 09:10:55 EST


On 3 May 2025, at 1:40, Donet Tom wrote:

> The function register_memory_blocks_under_node() is now only called from
> the memory hotplug path, as register_memory_blocks_under_node_early()
> handles registration during early boot. Therefore, the context argument
> used to differentiate between early boot and hotplug is no longer needed
> and was removed.
>
> Since the function is only called from the hotplug path, we renamed
> register_memory_blocks_under_node() to
> register_memory_blocks_under_node_hotplug()
>
> Signed-off-by: Donet Tom <donettom@xxxxxxxxxxxxx>
>
> ---
>
> v2->v3
>
> Removed context argument from register_memory_blocks_under_node()
> Renamed register_memory_blocks_under_node() to
> register_memory_blocks_under_node_hotplug()
>
> v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@xxxxxxxxxxxxx/
> v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@xxxxxxxxxxxxx/
> ---
> drivers/base/node.c | 5 ++---
> include/linux/node.h | 11 +++++------
> mm/memory_hotplug.c | 5 ++---
> 3 files changed, 9 insertions(+), 12 deletions(-)
>

LGTM. Acked-by: Zi Yan <ziy@xxxxxxxxxx>

--
Best Regards,
Yan, Zi