Re: [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection, RX and TX support.

[ALOK TIWARI]

On 23-04-2025 12:53, Parvathi Pudi wrote:
> From: Roger Quadros <rogerq@xxxxxx>
>
> Changes corresponding to link configuration such as speed and duplexity.
> IRQ and handler initializations are performed for packet reception.Firmware
> receives the packet from the wire and stores it into OCMC queue. Next, it
> notifies the CPU via interrupt. Upon receiving the interrupt CPU will
> service the IRQ and packet will be processed by pushing the newly allocated
> SKB to upper layers.
>
> When the user application want to transmit a packet, it will invoke
> sys_send() which will inturn invoke the PRUETH driver, then it will write

typo in turn

> the packet into OCMC queues. PRU firmware will pick up the packet and
> transmit it on to the wire.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> Signed-off-by: Basharath Hussain Khaja <basharath@xxxxxxxxxxx>
> Signed-off-by: Parvathi Pudi <parvathi@xxxxxxxxxxx>
> ---
[clip]
> +}
> +
> +/**
> + * icssm_emac_ndo_start_xmit - EMAC Transmit function
> + * @skb: SKB pointer
> + * @ndev: EMAC network adapter
> + *
> + * Called by the system to transmit a packet  - we queue the packet in

remove extra ' ' after packet

> + * EMAC hardware transmit queue
> + *
> + * Return: enum netdev_tx
> + */
> +static enum netdev_tx icssm_emac_ndo_start_xmit(struct sk_buff *skb,
> +						struct net_device *ndev)
> +{
> +	struct prueth_emac *emac = netdev_priv(ndev);
> +	int ret;


Thanks,
Alok