Re: [PATCH v3] x86/sev: Fix making shared pages private during kdump

[Tom Lendacky]

On 5/2/25 14:32, Kalra, Ashish wrote:
> Hello Tom,
> 
> On 5/1/2025 8:56 AM, Tom Lendacky wrote:
>> On 4/30/25 18:17, Ashish Kalra wrote:
>>> From: Ashish Kalra <ashish.kalra@xxxxxxx>

> 
> I agree, i really don't need the check as i can simply apply the mask as
> the mask is based on page level/size.
> 
> mask = page_level_mask(level);
> ghcb = (struct ghcb *)((unsigned long)ghcb & mask);

There's also a lot of casting back and forth with the ghcb variable. It
might be better to define it as an unsigned long and reduce all that.

Thanks,
Tom

>