Re: [PATCH v3 15/23] media: iris: Improve last flag handling

From: Bryan O'Donoghue
Date: Fri May 02 2025 - 12:18:52 EST


On 01/05/2025 20:13, Dikshita Agarwal wrote:
Improve the handling of the V4L2_BUF_FLAG_LAST flag in the driver:
- Ensure that the last flag is not sent multiple times.
- Attach the last flag to the first capture buffer returned during
flush, triggered by a sequence change, addressing cases where the
firmware does not set the last flag.

Reviewed-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>
Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
I'm sure this is logically correct, I just wonder if you could represent it as a inst->state instead of as a flag ?

Up to you to think about.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>