Re: [PATCH v3 8/9] media: i2c: ov9282: add strobe_duration v4l2 control
From: Sakari Ailus
Date: Thu May 01 2025 - 18:23:00 EST
Hi Richard,
On Wed, Apr 30, 2025 at 11:09:30AM +0200, Richard Leitner wrote:
> Hi Sakari,
>
> thanks for the review!
You're welcome.
> > > + v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION,
> >
> > Should the number of controls in the handler be updated?
>
> What do you mean by "number of controls in the handler" exactly? Which
> handler?
A number of buckets allocated in control handler's initialisation is based
on the number of controls given to the init function. You should update
that number when adding controls.
--
Regards,
Sakari Ailus