[PATCH 1/8] Staging: gpib: agilent_82357a: changing return type void in int

From: Thomas Andreatta
Date: Thu May 01 2025 - 17:31:02 EST


Patched FIXME request moving the return type from a void to int.

Signed-off-by: Thomas Andreatta <thomas.andreatta2000@xxxxxxxxx>
---
drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
index da229965d98e..ce2d3850ba31 100644
--- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -754,8 +754,7 @@ static int agilent_82357a_go_to_standby(struct gpib_board *board)
return 0;
}

-//FIXME should change prototype to return int
-static void agilent_82357a_request_system_control(struct gpib_board *board,
+static int agilent_82357a_request_system_control(struct gpib_board *board,
int request_control)
{
struct agilent_82357a_priv *a_priv = board->private_data;
@@ -765,7 +764,7 @@ static void agilent_82357a_request_system_control(struct gpib_board *board,
int i = 0;

if (!a_priv->bus_interface)
- return; // -ENODEV;
+ return -ENODEV;

usb_dev = interface_to_usbdev(a_priv->bus_interface);
/* 82357B needs bit to be set in 9914 AUXCR register */
@@ -785,7 +784,7 @@ static void agilent_82357a_request_system_control(struct gpib_board *board,
retval = agilent_82357a_write_registers(a_priv, writes, i);
if (retval)
dev_err(&usb_dev->dev, "write_registers() returned error\n");
- return;// retval;
+ return retval;
}

static void agilent_82357a_interface_clear(struct gpib_board *board, int assert)
--
2.34.1