Re: [REGRESSION][BISECTED] erroneous buffer overflow detected in bch2_xattr_validate

From: Jan Hendrik Farr
Date: Thu May 01 2025 - 13:22:30 EST


>
> I wonder if the __counted_by(x_name_len) in struct bch_xattr is needed, since there is also a value after x_name.

Wait a minute. Are you saying that the value with length x_val_len
is behind the name (of length x_name_len) at the end of the struct.
So essentially the flexible array member x_name has a length of
x_name_len + x_val_len and contains both the name and value?

If that's the case:

1. that's not at all clear from the struct definition
2. __counted_by(x_name_len) is not correct in that case


Best Regards
Jan