Re: [PATCHv2] wifi: ath9k: ahb: do ioremap resource in one step

[Toke Høiland-Jørgensen]

Rosen Penev <rosenp@xxxxxxxxx> writes:

> On Tue, Apr 22, 2025 at 5:35 AM Toke Høiland-Jørgensen <toke@xxxxxxx> wrote:
>>
>> Rosen Penev <rosenp@xxxxxxxxx> writes:
>>
>> > Simplifies probe slightly and adds extra error codes.
>> >
>> > Switching from devm_ioremap to the platform variant ends up calling
>> > devm_request_mem_region, which reserves the memory region for the
>> > various wmacs. Per board, there is only one wmac and after some fairly
>> > thorough analysis, there are no overlapping memory regions between wmacs
>> > and other devices on the ahb.
>> >
>> > Tested on a TP-Link Archer C7v2.
>> >
>> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
>> > ---
>> >  v2: remove wrong devm irq conversion.
>> >  drivers/net/wireless/ath/ath9k/ahb.c | 13 +++----------
>> >  1 file changed, 3 insertions(+), 10 deletions(-)
>>
>> Is there any benefit from this other than code simplification? Because,
>> TBH, I'm not sure saving 7 lines of code is worth the risk of changing
>> something we know works already...
> It's the same API calls fundamentally. This change has already been
> done treewide across various drivers.

Hmm, alright, let's give it a shot...

-Toke