Re: [net-next v7 4/7] net: mtip: The L2 switch driver for imx287

[Lukasz Majewski]

Hi Krzysztof, Jakub,

> On 25/04/2025 03:11, Jakub Kicinski wrote:
> > On Wed, 23 Apr 2025 09:29:08 +0200 Lukasz Majewski wrote:  
> >> This patch series provides support for More Than IP L2 switch
> >> embedded in the imx287 SoC.
> >>
> >> This is a two port switch (placed between uDMA[01] and
> >> MAC-NET[01]), which can be used for offloading the network traffic.
> >>
> >> It can be used interchangeably with current FEC driver - to be more
> >> specific: one can use either of it, depending on the requirements.
> >>
> >> The biggest difference is the usage of DMA - when FEC is used,
> >> separate DMAs are available for each ENET-MAC block.
> >> However, with switch enabled - only the DMA0 is used to
> >> send/receive data to/form switch (and then switch sends them to
> >> respecitive ports).  
> > 
> > Lots of sparse warnings and build issues here, at least on x86.
> > 
> > Could you make sure it's clean with an allmodconfig config, 
> > something like:
> > 
> > make C=1 W=1 drivers/net/ethernet/freescale/mtipsw/   
> 
> ... and W=1 with clang as well.
> 

The sparse warnings are because of struct switch_t casting and register
access with this paradigm (as it is done with other drivers).

What is the advise here from the community?

> Best regards,
> Krzysztof




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: pgpNa8jbHLm2e.pgp
Description: OpenPGP digital signature