Re: [PATCH v9 15/15] platform/x86: oxpec: Rename rval to ret in tt_toggle

[Ilpo Järvinen]

On Thu, 17 Apr 2025, Antheas Kapenekakis wrote:

> Rename the variable `rval` to `ret` in the function
> to follow conventions.

This and a few other changelogs use exceptionally short paragraph width, 
please reflow.

--
 i.

> 
> Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> ---
>  drivers/platform/x86/oxpec.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index ce20bf70027df..93d4abf8c3b8a 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -409,19 +409,19 @@ static ssize_t tt_toggle_store(struct device *dev,
>  			       size_t count)
>  {
>  	bool value;
> -	int rval;
> +	int ret;
>  
> -	rval = kstrtobool(buf, &value);
> -	if (rval)
> -		return rval;
> +	ret = kstrtobool(buf, &value);
> +	if (ret)
> +		return ret;
>  
>  	if (value) {
> -		rval = tt_toggle_enable();
> +		ret = tt_toggle_enable();
>  	} else {
> -		rval = tt_toggle_disable();
> +		ret = tt_toggle_disable();
>  	}
> -	if (rval)
> -		return rval;
> +	if (ret)
> +		return ret;
>  
>  	return count;
>  }
>